[PATCH] Including device.h and resource.h header files in linux/amba/bus.h

Linus Walleij linus.ml.walleij at gmail.com
Sat Mar 27 05:13:16 EDT 2010


2010/3/27 viresh kumar <viresh.linux at gmail.com>:

> Some time back i have initiated a thread regarding this type of issues. You can
> find them here:
>
> http://lists.infradead.org/pipermail/linux-arm-kernel/2010-February/010258.html
>
> And my understanding after the discussion was:
>
> It is the responsibility of a header files, using types definitions
> from outside world,
> to include all header files required for proper compilation.
> This is not the responsibility of the user using this file to add
> dependency header in
> his source files.

On the other hand Documentation/SubmitChecklist contains this:

1: If you use a facility then #include the file that defines/declares
   that facility.  Don't depend on other header files pulling in ones
   that you use.

Then this falls back on the definition of "facility". (And other academic
discussions.)

I guess Russell will need to decide on this.

Linus



More information about the linux-arm-kernel mailing list