AACI broken with commit 29a4f2d3

Catalin Marinas catalin.marinas at arm.com
Fri Mar 26 09:00:10 EDT 2010


On Fri, 2010-03-26 at 11:28 +0000, Philby John wrote:
> --- a/sound/arm/aaci.c
> +++ b/sound/arm/aaci.c
> @@ -863,7 +863,11 @@ static int __devinit aaci_probe_ac97(struct aaci *aaci)
>         struct snd_ac97 *ac97;
>         int ret;
> 
> -       writel(0, aaci->base + AC97_POWERDOWN);
> +       /*
> +        * Fix: ac97 read back fail errors by reading
> +        * from Power down register
> +        */
> +       readw(aaci->base + 0x26);

I still don't understand this. Does aaci->base point to the AACI
registers? There is no register at offset 0x26 but there is one at 0x24
(32-bit AACIIE2).

-- 
Catalin




More information about the linux-arm-kernel mailing list