[PATCH v2] PL330: Add PL330 DMA controller driver
jy0922.shim at samsung.com
Thu Mar 25 06:05:47 EDT 2010
On 3/25/2010 6:32 PM, Marc Zyngier wrote:
> On Thu, 25 Mar 2010 18:01:00 +0900, Joonyoung Shim
> <jy0922.shim at samsung.com> wrote:
>> On 3/25/2010 2:44 PM, Marc Zyngier wrote:
>>> On Thu, 25 Mar 2010 12:17:15 +0900
>>> Joonyoung Shim <jy0922.shim at samsung.com> wrote:
>>>> + writew(imm, desc_pool_virt);
>> Right. The write[bwl] is api for address ioremapped of io device. I will
>> change these.
>>> Does anything ensure that this won't generate an unaligned access?
>> PL330 DMA controller fetches variable length instructions that consist
>> one to six bytes, so i think unaligned access is no problem.
> I'm not too concerned about the device side of things. I'm more worried
> about the CPU access when writing the 'imm' value to memory.
> Consider desc_pool_virt 16bit aligned when entering the function. Writing
> the opcode makes it unaligned and then writing the 'imm' value will result
> as an unaligned access.
Why desc_pool_virt should be aligned more than 16bit?
More information about the linux-arm-kernel