AACI broken with commit 29a4f2d3
Will Deacon
will.deacon at arm.com
Wed Mar 24 11:18:06 EDT 2010
Hi Catalin,
> aaci: Use writew() to the AC97_POWERDOWN 16-bit register
>
> From: Catalin Marinas <catalin.marinas at arm.com>
>
> The writel() introduced by commit 29a4f2d3 generates an alignment fault
> on ARM.
>
> Signed-off-by: Catalin Marinas <catalin.marinas at arm.com>
> Cc: Philby John <pjohn at in.mvista.com>
> Cc: Takashi Iwai <tiwai at suse.de>
> ---
> sound/arm/aaci.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/arm/aaci.c b/sound/arm/aaci.c
> index 656e474..d66d4ff 100644
> --- a/sound/arm/aaci.c
> +++ b/sound/arm/aaci.c
> @@ -863,7 +863,7 @@ static int __devinit aaci_probe_ac97(struct aaci *aaci)
> struct snd_ac97 *ac97;
> int ret;
>
> - writel(0, aaci->base + AC97_POWERDOWN);
> + writew(0, aaci->base + AC97_POWERDOWN);
> /*
> * Assert AACIRESET for 2us
> */
A writel() looks wrong anyway because even if it could succeed, it would
send half of its write to AC97_EXTENDED_ID, which sounds suspiciously read-only
to me.
Tested-by: Will Deacon <will.deacon at arm.com>
Will
More information about the linux-arm-kernel
mailing list