[PATCH] Voipac PXA270: UDC and UHC support

[Eric Miao]

On Mon, Mar 22, 2010 at 11:28 AM, Marek Vasut <marek.vasut at gmail.com> wrote:
> Dne Po 22. března 2010 02:57:33 Eric Miao napsal(a):
>> >> +static void vpac270_udc_command(int cmd)
>> >> +{
>> >> +     if (cmd == PXA2XX_UDC_CMD_CONNECT)
>> >> +             UP2OCR |= UP2OCR_HXOE | UP2OCR_DPPUE | UP2OCR_DPPUBE;
>> >> +     else if (cmd == PXA2XX_UDC_CMD_DISCONNECT)
>> >> +             UP2OCR &= ~(UP2OCR_HXOE | UP2OCR_DPPUE | UP2OCR_DPPUBE);
>> >
>> > In the "DISCONNECT" case, you reset UP2OCR_HXOE, meaning the usb port
>> > isn't a USB Device anymore (neither a USB host). If that's on purpose,
>> > then all good, in the other case, don't reset that one.
>>
>> Marek??
>
> I wasn't able to get it running without reseting the HXOE (so it's there based
> on my tests with the hardware). I'll have to investigate it properly when I have
> more time.
>
> So Eric, could you push this in? I'll send a fix if I figure out something's
> wrong here.
>

Could you modify the patch a bit to leave a NOTE there in the
commit message so we can track? As well as Robert's reviewed-by.
Thanks.