[PATCH] locomo.c: spi register offset bugfix

Eric Miao eric.y.miao at gmail.com
Sun Mar 21 22:36:27 EDT 2010


On Thu, Mar 11, 2010 at 1:11 AM, H Hartley Sweeten
<hartleys at visionengravers.com> wrote:
> The locomo spi registers are all defined in locomo.h as offsets
> from the first spi register LOCOMO_SPI (0x60), which is itself
> an offset from the locomo base address.  To correctly access
> these registers LOCOMO_SPI must always be included in the
> address calculation.
>
> There are two places in locomo.c where this is not done.  The
> first one, in locomo_suspend, actually results in a write to
> LOCOMO_ST instead of LOCOMO_SPICT.  The second is in __locomo_probe
> and results in a write to LOCOMO_MCSX2 instead of LOCOMO_SPIIE.
>
> Fix these by including LOCOMO_SPI in the calculation.
>
> Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
> Cc: Eric Miao <eric.y.miao at gmail.com>
>

Applied to 'fix'.



More information about the linux-arm-kernel mailing list