[RFC/PATCH 09/10] [ARM] tegra: harmony: Add harmony board file

mike at compulab.co.il mike at compulab.co.il
Thu Mar 18 16:41:07 EDT 2010


On Wed, Mar 17, 2010 at 07:27:04PM -0700, Erik Gilling wrote:
> On Wed, Mar 17, 2010 at 1:21 AM, Mike Rapoport <mike at compulab.co.il> wrote:
> >
> > I think that both panel definition and pinmux can be in the board-harmony.c
> > and thus the board-harmony.h is not needed.
> 
> In our experience board files get sufficiently cluttered with platform
> device definitions, callbacks, and fixups that splitting them apart
> make them much easer to deal with.  See the sholes support at
> http://android.git.kernel.org/?p=kernel/omap.git;a=tree;f=arch/arm/mach-omap2;hb=android-omap-2.6.32
> .

I'm not sure that staring over with several small files for different
board features is that necessary. If the board file becomes bloated than
it'd make sense to split it. But a board file with three platform device
definitions and mux table is not that big...

> -Erik

--
Sincerely yours,
Mike.



More information about the linux-arm-kernel mailing list