[spi-devel-general] [PATCH 0/3] spi: driver for Cirrus EP93xx SPI controller

[H Hartley Sweeten]

On Monday, March 15, 2010 9:26 AM, Mika Westerberg wrote:
> Hello,
> 
> This series provides SPI master controller driver implementation for
> Cirrus Logic EP93xx controllers.
> 
> I've tested this on my TS-7260 board with SPI EEPROM (through at25 driver)
> and with few SD/MMC cards that I own (through mmc_spi driver). Unfortunately
> I don't have other SPI devices so if someone wants to try this, it would be
> great (see [1] for example code that I used with MMC cards).
> 
> This series applies on top of Linus' 2.6.34-rc1.
> 
> Please review.
> 
> Thanks,
> MW

Hello Mika,

I also have a SPI driver (originally from Bluewater Systems) that I have been
sitting on.  Your's has the advantage of using interrupts and is already
coded for 16-bit targets, mine is currently polled and only handles 8-bit
targets.

Based on that I'll try to help you get yours merged instead.

I already responded to patch 2/3.  Overall it's fine I would just like
the code moved a bit in the source files.  Please review the comments.

Patch 3/3 looks ok initially.  I think you are hindering the chip-select
options but I will work that out when I go through the patch 1/3.

Patch 1/3 looks good for a start.  The only problem I see is your
limitation to only using built-in gpio's for chipselects.

I will try to get your patches merged into my tree this week and test
them.  At that point I will provide more feedback and try to address
the chipselect limitation.

Thanks for the submission.

Regards,
Hartley