[Kgdb-bugreport] [PATCH] ARM: change definition of cpu_relax() for ARM11MPCore
Will Deacon
will.deacon at arm.com
Thu Mar 11 08:53:03 EST 2010
> Maybe we should initial the atomic_t variable before we using such as
> atomic_inc/dec() directly.
>
> Dongdong.
>
>
> --- a/kernel/kgdb.c
> +++ b/kernel/kgdb.c
> @@ -227,6 +227,17 @@ kgdb_post_primary_code(struct pt_regs *regs, int
> e_vector, int err_code)
> return;
> }
>
> +static void kgdb_initial_atomic_var()
> +{
> + int i;
> + for (i = NR_CPUS-1; i >= 0; i--) {
> + atomic_set(&passive_cpu_wait[i], 0);
> + atomic_set(&cpu_in_kgdb[i], 0);
> + }
> +
> + atomic_set(&kgdb_setting_breakpoint, 0);
> +}
> +
Given that passive_cpu_wait and cpu_in_kgdb are static, I think those guys
are alright as-is. kgdb_setting_breakpoint should probably be reset though.
Will
More information about the linux-arm-kernel
mailing list