[PATCH 1/2] mx1: fix build when DEBUG_LL is enabled

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Thu Mar 11 05:39:41 EST 2010


Hello,

On Tue, Mar 09, 2010 at 12:12:04PM +0200, Baruch Siach wrote:
> Commit "mx1: prefix SOC specific defines with MX1_ and deprecate old names"
> redefined the IO_ADDRESS macro in a way that is incompatible with
> debug-macro.S. Reintroduce AVIC_IO_ADDRESS, and use it in debug-macro.S.
This feels wrong.  Can you please instead fix IMX_IO_ADDRESS?

Something like:

	#ifdef __ASSEMBLY__
	#define IOREG(x) (x)
	#else
	#define IOREG(x) ((void __force __iomem *)(x))
	#endif

	#define IMX_IO_ADDRESS(addr, module) IOREG(\
	...

could work.  Don't know if the cast to unsigned long works in assembler.
Maybe it's unneeded?  Don't remember.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |



More information about the linux-arm-kernel mailing list