[PATCH 2.6.34] ARM: SAMSUNG: Fix build after "ARM: Eliminate decompressor -Dstatic= PIC hack"

[Russell King - ARM Linux]

On Wed, Mar 10, 2010 at 05:17:37PM +0000, Mark Brown wrote:
> On Mon, Mar 01, 2010 at 06:52:22PM +0000, Mark Brown wrote:
> > Commit 5de813b6 (ARM: Eliminate decompressor -Dstatic= PIC hack) among
> > other things changed the declared type of the error() function to an
> > extern, conflicting with the forward declartion in the Samsung
> > plat/uncompress.h which appears to have been relying on the static
> > being defined away, causing build failures since error() ends up with
> > a GOT relocation but the linker script discards all GOT relocated
> > data and functions:
> 
> This is now required in mainline (2.6.34-rc1 fails to build) - given the
> severity and lack of response I'm just going to go ahead and send it to
> the patch tracker, hope that's OK.

Why is error() being declared in this header file?