[PATCH 4/7] mmc: at91_mci: use DMA buffer for read
Wolfgang Mües
wolfgang.mues at auerswald.de
Wed Mar 3 02:34:31 EST 2010
Hi Andrew,
Am Dienstag, 2. März 2010 schrieb Andrew Morton:
> Nicolas Ferre <nicolas.ferre at atmel.com> wrote:
> > + kunmap_atomic(((void *)sgbuffer)-sg->offset, KM_BIO_SRC_IRQ);
>
> It's a feature of kunmap_atomic() that it will accept a pointer to any
> location in the page. So the subtraction isn't strictly needed.
>
> And if the subtraction is removed, the (void*) cast can also be removed.
I did not know this. Thank you for pointing this out. So this part of the
patch (which was purely cosmetic because I have seen no error without the
subtraction) can be omitted.
best regards
i. A. Wolfgang Mües
--
Auerswald Gesellschaft für Datensysteme mbH
Hardware Development
Telefon: +49 (0)5306 9219 562
Telefax: +49 (0)5306 9219 94
E-Mail: Wolfgang.Mues at Auerswald.de
Web: http://www.auerswald.de
--------------------------------------------------------------
Auerswald Gesellschaft für Datensysteme mbH
Vor den Grashöfen 1, 38162 Cremlingen
Registriert beim AG Braunschweig HRB 7499
Geschäftsführer: Dipl-Ing. Gerhard Auerswald
More information about the linux-arm-kernel
mailing list