[PATCH 3/4] pxa2xx/cpufreq: Fix PCMCIA frequency scaling

[Eric Miao]

On Fri, Jun 25, 2010 at 3:46 AM, Nicolas Pitre <nico at fluxnic.net> wrote:
> On Thu, 24 Jun 2010, Russell King - ARM Linux wrote:
>
>> On Thu, Jun 24, 2010 at 08:51:27PM +0200, Marek Vasut wrote:
>> > Dne St 23. června 2010 19:49:59 Robert Jarzmik napsal(a):
>> > > Marek Vasut <marek.vasut at gmail.com> writes:
>> > > > The MCxx values must be based off memory clock, not CPU core clock.
>> > > >
>> > > > This also fixes the bug where on some machines the LCD went crazy while
>> > > > using PCMCIA.
>> > >
>> > > That looks correct to me.
>> > >
>> > > Reviewed-by: Robert Jarzmik <robert.jarzmik at free.fr>
>> > >
>> > > Cheers.
>> > >
>> > > --
>> > > Robert
>> >
>> > Actually lemme rethink this ... it might still be incorrect.
>>
>> As Nicolas was the one who originally wrote that code, while he was
>> working for Montavista and interacting with Intel, I'd be surprised
>> if he didn't try finding out what the right answer is to that fixme.
>
> Well, I might have tried, or I might not have and this simply was never
> revisited. But I clearly don't remember any of the context anymore.
>
>> I suspect as the fixme remained that there was no clear answer.
>
> Whatever works in practice is probably the best answer at this point.
>

Fair enough. And this looks correct to me as well. Applied to 'fix'.