[PATCH V2] GPIO PL061: Adding Clk framework support

Rabin Vincent rabin at rab.in
Mon Jun 21 11:41:21 EDT 2010


On Mon, Jun 21, 2010 at 12:27:43PM +0530, Viresh KUMAR wrote:
> GPIO Clk is never enabled on Platforms, like: SPEAr, which are based upon clock
> framework and use PL061 driver. This patch adds support for Clk enabling and
> disabling as and when gpios are requested and freed.
[...]
> +	chip->clk = clk_get(&dev->dev, NULL);
> +	if (IS_ERR(chip->clk)) {
> +		ret = PTR_ERR(chip->clk);
> +		goto iounmap;
> +	}

Have you verified that all platforms using this driver already have
clocks with the appropriate names?   Otherwise this patch will break
those platforms.

Rabin



More information about the linux-arm-kernel mailing list