gpiolib and sleeping gpios

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Mon Jun 21 01:09:57 EDT 2010


Hi,

On Sun, Jun 20, 2010 at 07:40:46PM -0700, David Brownell wrote:
> > > And they will trigger runtime warnings, and
> > > thus eventually get fixed.
> > \
> >   }
> > 
> >   err = gpio_request(some_gpio, "some_gpio",
> >           GPIOF_NO_SLEEP);
> 
> 
> NAK ... keep it simple.  Such flags are
> clearly not necessary...
> 
> I understand that some folk are bothered
> by concepts/frameworks that seem "too simple"
> and thus want to complexify them.  In this
> case I am in a position to help avoid that.
> Complexity is not a virtue.
I'm against such an additional flag, too.  But I still think merging
gpio_get_value and gpio_get_value_cansleep is nice.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |



More information about the linux-arm-kernel mailing list