[PATCH 1/2] mxc: add common debug board for 3-stack platforms
jason77.wang at gmail.com
Fri Jun 18 10:06:34 EDT 2010
Sascha Hauer wrote:
> On Sat, Jun 12, 2010 at 10:25:06PM +0800, Jason Wang wrote:
>> The debug board is little different for all mxc 3-stack(PDK)
>> platforms, it is possible here to add a common implementation to
>> support this board.
> Two small things left:
> Could you change the name cpld_debugboard.c to something like
> 3ds_debugboard.c? That we are talking about the 3ds is much more
> interesting than that there's a cpld on the board.
> Also, I really prefer having no extra header file for the debug board.
> All information in this header file is only interesting in this single C
About the header file, most contents can be moved to c file,
but there are two declarations:
extern struct platform_device smsc_lan9217_device;
int __init mxc_expio_init(u32 base, u32 p_irq);
which will be used by board_mxNN_3ds.c, should i move them to mach/common.h and
drop 3ds_debugboard.h or keep them in 3ds_debugboard.h?
>> Signed-off-by: Jason Wang <jason77.wang at gmail.com>
>> arch/arm/plat-mxc/Kconfig | 11 ++
>> arch/arm/plat-mxc/Makefile | 1 +
>> arch/arm/plat-mxc/cpld_debugboard.c | 161 ++++++++++++++++++++++
More information about the linux-arm-kernel