[PATCH 3/4] arch/arm/mach-kirkwood: add support for 2nd PCIe port on 88f6282.

Benjamin Zores benjamin.zores at alcatel-lucent.com
Thu Jun 17 02:58:38 EDT 2010


On 10/06/2010 17:29, saeed bishara wrote:
>
> you didn't updated the comment the describes the address map.
> also, I suggest you to take this part from the patch I sent, in that
> patch I made sure to make the pcie1 IO physical and virtual address
> consecutive to pcie0, I think without this the IO access to pcie1 will
> not work. please see the __io() macro at
> mach-kirkwood/include/mach/io.h
>    

Will do.

>>      
> you're still using the pcie_port global structure. the patch I sent
> removed it,  can you take this part (changes to kirkwood/pcie.c) from
> my patch?
>    

I removed these parts of your patch because PCIe was no longer working 
on my board with this approach.
I took the same one that was used in mach-mv78xx0.

Ben



More information about the linux-arm-kernel mailing list