[PATCH 02/10] arm/zImage: some comments for __armv3_mpu_cache_on

[Russell King - ARM Linux]

On Wed, Jun 16, 2010 at 11:16:43AM +0800, Eric Miao wrote:
> >                mrc     p15, 0, r0, c1, c0, 0   @ read control reg
> >                                                @ .... .... .... WC.M
> >                orr     r0, r0, #0x000d         @ .... .... .... 11.1
> > +               /* ?? this overwrites the value constructed above? */
> >                mov     r0, #0
> 
> This does seem to be an error.

If we can't test the removal of that line, we have to assume that the
existing code was tested, and did work.  (It certainly will work, but
slower because the caches would not be on.)  We don't know if removing
this line would cause problems.

I think it's better just to add a comment about it, and leave the code
as-is.

However, if someone has an ARM740T system and can test the removal of
this, then we can remove it.  I suspect that ARM740T systems are rarely
worked on now though - esp. as the whole nommu stuff doesn't seem to
get much attention.