[PATCH 2/2] ehci-mxc: bail out on transceiver problems

Daniel Mack daniel at caiaq.de
Wed Jun 16 01:35:19 EDT 2010


On Wed, Jun 16, 2010 at 03:44:58AM +0200, Wolfram Sang wrote:
> On Tue, Jun 15, 2010 at 12:43:42PM +0200, Daniel Mack wrote:
> > On Tue, Jun 15, 2010 at 12:34:23PM +0200, Wolfram Sang wrote:
> > > The old code registered the hcd even if there were no transceivers
> > > detected, leading to oopses like this if we try to probe a non-existant
> > > ULPI:
> > 
> > Hmm. I'm aware that there was a missing bail in this function, but
> > actually, I had hardware which didn't properly detect the ULPI chip but
> > still worked fine. There has been quite some discussion here about that,
> > and eventually I decided to not make this a hard error as it didn't
> > really harm.
> 
> Hmm, so, do you think this patch is stable-material after all?

Hard to say. It might break existing board support, which would be a
regression. OTOH, it fixes an Oops. Don't know really ...

Daniel



More information about the linux-arm-kernel mailing list