[PATCH 1/5] SPEAr3xx: Make local structres static

Viresh KUMAR viresh.kumar at st.com
Mon Jun 14 01:41:34 EDT 2010


On 6/14/2010 11:01 AM, Ryan Mallon wrote:
>>> -struct pmx_dev_mode pmx_plgpio_45_46_49_50_modes[] = {
>>> >> +static struct pmx_dev_mode pmx_plgpio_45_46_49_50_modes[] = {
>>> >>  	{
>>> >>  		.ids = 0x00,
>>> >>  		.mask = PMX_TIMER_3_4_MASK,
>> > 
>> > These structures are not local, they are used in spear3**_evb.c files,
>> > and hence can't be static.
> The pmx_dev structures are used by the spear3**_evb.c files, but the
> pmx_dev_mode structures are local. This patch is only making the latter
> static. I have done a build test which includes all three spear3**_evb
> board files and got no compilation warnings/errors.

sorry!! You were correct.



More information about the linux-arm-kernel mailing list