[PATCH 4/5] [ARM] usb/host/ohci-pxa27x: make PXA310 USB OTG port work in host mode.

[Mike Rapoport]

Eric Miao wrote:
> On Sun, Jun 13, 2010 at 2:57 PM, Mike Rapoport <mike at compulab.co.il> wrote:
>> Eric Miao wrote:
>>> On Wed, Jun 2, 2010 at 3:40 PM, Igor Grinberg <grinberg at compulab.co.il>
>>> wrote:
>>>> Signed-off-by: Igor Grinberg <grinberg at compulab.co.il>
>>>> Signed-off-by: Mike Rapoport <mike at compulab.co.il>
>>>> ---
>>>>  arch/arm/mach-pxa/include/mach/ohci.h     |    3 +
>>>>  arch/arm/mach-pxa/include/mach/regs-u2d.h |    2 +
>>>>  drivers/usb/host/ohci-pxa27x.c            |  183
>>>> +++++++++++++++++++++++++++++
>>> My feeling is on pxa310, the OTG/ULPI is actually closer to the UDC, so
>>> generally, I'd really like to see minimum change to ohci.
>> There are certain registers set up that should be done in order to enable
>> the pxa310 otg port in the host mode. I agree that most of them should be
>> done in the UDC driver, but since there's no UDC driver at all for pxa310,
> 
> Wow, that's a big problem.
 >
>> the most logical place for those register set ups would be pxa ohci glue
>> driver.
>>
> 
> So, is there a simple way to setup the ULPI for the host within mach-pxa/*?
> We need really really simple code for that, so it has minimum impact when
> we move that part into pxa310-udc.c? I still want ohci-pxa27x to remain
> minimum impacted.

we can put most of the code in, say, arch/arm/mach-pxa/pxa3xx-u2d.c and 
add hooks in ohci-pxa27x.

-- 
Sincerely yours,
Mike.