[PATCH 03/10] arm/zImage: __armv3_mpu_cache_flush: respect should-be-zero specification

Eric Miao eric.miao at canonical.com
Thu Jun 10 21:23:31 EDT 2010


2010/6/10 Uwe Kleine-König <u.kleine-koenig at pengutronix.de>:
> Probably the register content for cache operations is "don't care" in
> practice, but as r1 is explicitly zeroed, use that one.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> ---
>  arch/arm/boot/compressed/head.S |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/boot/compressed/head.S b/arch/arm/boot/compressed/head.S
> index 384150b..4058294 100644
> --- a/arch/arm/boot/compressed/head.S
> +++ b/arch/arm/boot/compressed/head.S
> @@ -991,7 +991,7 @@ no_cache_id:
>  __armv3_mmu_cache_flush:
>  __armv3_mpu_cache_flush:
>                mov     r1, #0
> -               mcr     p15, 0, r0, c7, c0, 0   @ invalidate whole cache v3
> +               mcr     p15, 0, r1, c7, c0, 0   @ invalidate whole cache v3
>                mov     pc, lr

And this is at least more consistent with arch/arm/mm/cache-v3.S, so

Acked-by: Eric Miao <eric.miao at canonical.com>



More information about the linux-arm-kernel mailing list