[PATCH 02/10] arm/zImage: some comments for __armv3_mpu_cache_on

Sergei Shtylyov sshtylyov at mvista.com
Thu Jun 10 17:36:06 EDT 2010


Hello.

Uwe Kleine-König wrote:

> __armv3_mpu_cache_on seems broken.  As there is noone around who knows
> about these machines just keep the code as is but point out the strange
> things.

> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> ---
>  arch/arm/boot/compressed/head.S |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boot/compressed/head.S b/arch/arm/boot/compressed/head.S
> index 390aa92..384150b 100644
> --- a/arch/arm/boot/compressed/head.S
> +++ b/arch/arm/boot/compressed/head.S
> @@ -396,12 +396,15 @@ __armv3_mpu_cache_on:
>  
>  		mov	r0, #0
>  		mcr	p15, 0, r0, c7, c0, 0	@ invalidate whole cache v3
> +		/* ?? ARMv3 MMU doesn not allow reading the control register, does this really work on ARMv3 MPU? */

    Only "does not".

WBR, Sergei



More information about the linux-arm-kernel mailing list