[PATCH v3] ep93xx: move physmap flash registration into core.c
H Hartley Sweeten
hartleys at visionengravers.com
Wed Jun 9 17:10:18 EDT 2010
On Wednesday, June 09, 2010 1:59 PM, Ryan Mallon wrote:
> H Hartley Sweeten wrote:
>> Create a core.c __init function to handle the physmap flash
>> registration for all the ep93xx platforms. Also, modify all
>> the ep93xx platforms to use this new function.
>>
>> This simplifies all the ep93xx platform init code and removes
>> all the static variables that would exist in a unified kernel
>> supporting multiple ep93xx platforms.
>
> Looks fine. Not sure I understand the second part about the unified
> kernel though. Can't we already build all ep93xx boards (at least those
> at the same phys offset) into one kernel?
Yes, we already build a unified kernel for boards with the same phys
offset. But with the current code each platform has a private static
Resource and platform device for the flash. Since this data is not
tagged as __initdata it just takes up space after initialization. If
a working runtime PHYS_OFFSET patch is ever worked out this static
data will increase for each ep93xx platform added.
Maybe "unified" is not the right term...
Regards,
Hartley
More information about the linux-arm-kernel
mailing list