[PATCH] Marvell OpenRD-Ultimate machine support
Lennert Buytenhek
buytenh at wantstofly.org
Wed Jun 9 16:42:57 EDT 2010
On Wed, Jun 09, 2010 at 09:39:29PM +0100, Alexander Clouter wrote:
> > > kirkwood_ge00_init(&openrd_ge00_data);
> > > - if (machine_is_openrd_client())
> > > + if (machine_is_openrd_client() || \__same line
> > > + machine_is_openrd_ultimate()) /
> > > kirkwood_ge01_init(&openrd_ge01_data);
> > > + <------- REMOVE
> > > kirkwood_sata_init(&openrd_sata_data);
> > > kirkwood_sdio_init(&openrd_mvsdio_data);
> > >
> > As that 'if()' clause is still less than 77 chars wide:
> > ----
> > kirkwood_ge00_init(&openrd_ge00_data);
> > if (machine_is_openrd_client() || machine_is_openrd_ultimate())
> > kirkwood_ge01_init(&openrd_ge01_data);
> > kirkwood_sata_init(&openrd_sata_data);
> > kirkwood_sdio_init(&openrd_mvsdio_data);
> > ----
>
> Better still, just make this 'if(!machine_is_openrd_base())'.
That form is more error prone when someone adds the OpenRD-SuperDuper,
though.
More information about the linux-arm-kernel
mailing list