[PATCH] RTC/pxa: remove unnecessary private ops->ioctl()

Eric Miao eric.y.miao at gmail.com
Mon Jun 7 05:31:46 EDT 2010


On Mon, Jun 7, 2010 at 4:47 PM, Robert Jarzmik <robert.jarzmik at free.fr> wrote:
> Wan ZongShun <mcuos.com at gmail.com> writes:
>> Please, do not implement private ops->ioctl() unless absolutely necessary.
>> pxa series RTC driver's ioctl() is unnecessary, since RTC subsystem has implement
>> the ioctl() very well,so we can only use the API of '.alarm_irq_enable' and
>> '.update_irq_enable' to do enable irq action.
>>
>> Signed-off-by: Wan ZongShun <mcuos.com at gmail.com>
> Acked-by: Robert Jarzmik <robert.jarzmik at free.fr>
>
> This is not an urgent fix, but a cleanup. Whoever gets it in (Alessandro through
> rtc tree, Eric through arm/pxa tree, or Andrew) is to be defined.
>
> I would go for Alessandro, as he handles the RTC tree.
>

Yeah, Acked-by: Eric Miao <eric.y.miao at gmail.com>



More information about the linux-arm-kernel mailing list