[PATCH] RTC/pxa: remove unnecessary private ops->ioctl()

Robert Jarzmik robert.jarzmik at free.fr
Mon Jun 7 04:47:05 EDT 2010


Wan ZongShun <mcuos.com at gmail.com> writes:
> Please, do not implement private ops->ioctl() unless absolutely necessary.
> pxa series RTC driver's ioctl() is unnecessary, since RTC subsystem has implement
> the ioctl() very well,so we can only use the API of '.alarm_irq_enable' and
> '.update_irq_enable' to do enable irq action.
>
> Signed-off-by: Wan ZongShun <mcuos.com at gmail.com>
Acked-by: Robert Jarzmik <robert.jarzmik at free.fr>

This is not an urgent fix, but a cleanup. Whoever gets it in (Alessandro through
rtc tree, Eric through arm/pxa tree, or Andrew) is to be defined.

I would go for Alessandro, as he handles the RTC tree.

Cheers.

--
Robert

PS: Removed alsa-devel list, as this is not alsa material



More information about the linux-arm-kernel mailing list