[V2 3/3] mx51/keypad: add keypad support for i.MX51 platforms
jason
jason77.wang at gmail.com
Sat Jun 5 10:13:34 EDT 2010
Alberto Panizzo wrote:
> On gio, 2010-06-03 at 20:05 +0800, Jason Wang wrote:
>
>> Add keypad controller device definition for all i.MX51 platforms,
>> add a dummy kpp clock for imx keypad driver and add keypad device
>> registration on i.MX51 3-stack board.
>>
>> Signed-off-by: Jason Wang <jason77.wang at gmail.com>
>> ---
>> arch/arm/mach-mx5/board-mx51_3ds.c | 59 ++++++++++++++++++++++++++++++++++++
>> arch/arm/mach-mx5/clock-mx51.c | 5 +++
>> arch/arm/mach-mx5/devices.c | 19 +++++++++++
>> arch/arm/mach-mx5/devices.h | 1 +
>> 4 files changed, 84 insertions(+), 0 deletions(-)
>>
>
> May you wont divide platform vs machine code in two different patches.
>
Thanks for your comments, but here i don't really know what you mean,
should i divide this patch to 2 patches or ?
> and, Eric Bénard is working on imx_keypad suspend/resume features[1] and
> about it, he is going to modify the platform interface that make us able
> to register the device.. this patch could look old in a few.
>
> [1]http://thread.gmane.org/gmane.linux.ports.arm.kernel/80968/focus=13131
>
> Best regards,
> Alberto!
>
>
Yes, reading this thread, my platform interface is old.
I just git pull the upstream, it seems that new interface change hasn't
been merged,
i will modify this interface if it is merged into the upstream.
Thanks,
Jason.
>> diff --git a/arch/arm/mach-mx5/board-mx51_3ds.c b/arch/arm/mach-mx5/board-mx51_3ds.c
>> index 5da90e9..abc9f87 100644
>> --- a/arch/arm/mach-mx5/board-mx51_3ds.c
>> +++ b/arch/arm/mach-mx5/board-mx51_3ds.c
>> @@ -16,6 +16,7 @@
>>
<snip>
More information about the linux-arm-kernel
mailing list