[PATCH 1/3] MTD/pxa: patch for error return value method of pxa2xx-flash.c

[Eric Miao]

On Sat, Jun 5, 2010 at 3:53 PM, Wan ZongShun <mcuos.com at gmail.com> wrote:
> Hi Eric,
>
> This following piece of code:
>
>        if (!info->map.virt) {
>                printk(KERN_WARNING "Failed to ioremap %s\n",
>                       info->map.name);
>                ret = -ENOMEM;
>                goto fail2;
>        }
>
> Shouldn't  the 'KERN_ERR' in stead of the 'KERN_WARNING '?
> Because the  'info->map.virt == NULL' can arouse the serious crash.
>

The thing is you need to figure out if it is mandatory because we
have another info->map.cached just in case. Disaster is both can
not be mapped.