[PATCH 3/4] ARM: cns3xxx: Add support for AHCI controllers

[Anton Vorontsov]

On Wed, Jun 02, 2010 at 04:54:57PM +0400, Sergei Shtylyov wrote:
[...]
> >>>+	/* De-Asscer SATA Reset */
> >>>+	tmp = PM_SOFT_RST_REG;
> >>>+	tmp |= 0x1 << PM_SOFT_RST_REG_OFFST_SATA;
> >>   You have *REG_OFFSET* everywhere, and *REG_OFFST* here -- a typo?
> 
> >No, this is how PM_SOFT_RST_REG_OFFST_* bits actually named.
> 
>    Then I guess it's the typo(s) there. ;-)

Or maybe other "OFFSET"s were meant to be "OFFST", e.g. for less
typing, who knows? :-)

But sure, I agree, cns3xxx.h's bit descriptions could be better.
In my todo list now.

Thanks,

-- 
Anton Vorontsov
email: cbouatmailru at gmail.com
irc://irc.freenode.net/bd2