[PATCH v3 0/3] Ordered I/O accessors

Russell King - ARM Linux linux at arm.linux.org.uk
Thu Jul 29 06:44:28 EDT 2010


On Wed, Jul 28, 2010 at 06:18:47PM +0530, Rabin VINCENT wrote:
> Something like the following needs to be applied to fix it.  I'll submit
> this as a separate patch if it can't be folded in.

Please submit it as a separate patch to the patch system.  Thanks.

> diff --git a/arch/arm/mach-ux500/include/mach/uncompress.h b/arch/arm/mach-ux500/include/mach/uncompress.h
> index 8552eb1..0271ca0 100644
> --- a/arch/arm/mach-ux500/include/mach/uncompress.h
> +++ b/arch/arm/mach-ux500/include/mach/uncompress.h
> @@ -30,22 +30,22 @@
>  static void putc(const char c)
>  {
>  	/* Do nothing if the UART is not enabled. */
> -	if (!(readb(U8500_UART_CR) & 0x1))
> +	if (!(__raw_readb(U8500_UART_CR) & 0x1))
>  		return;
>  
>  	if (c == '\n')
>  		putc('\r');
>  
> -	while (readb(U8500_UART_FR) & (1 << 5))
> +	while (__raw_readb(U8500_UART_FR) & (1 << 5))
>  		barrier();
> -	writeb(c, U8500_UART_DR);
> +	__raw_writeb(c, U8500_UART_DR);
>  }
>  
>  static void flush(void)
>  {
> -	if (!(readb(U8500_UART_CR) & 0x1))
> +	if (!(__raw_readb(U8500_UART_CR) & 0x1))
>  		return;
> -	while (readb(U8500_UART_FR) & (1 << 3))
> +	while (__raw_readb(U8500_UART_FR) & (1 << 3))
>  		barrier();
>  }
>  



More information about the linux-arm-kernel mailing list