[rtc-linux] [PATCH 2/2] rtc: rtc-s3c: Updates RTC driver for clock enabling support

[Kukjin Kim]

Wan ZongShun wrote:
> 
> 2010/7/22 Atul Dahiya <atuldahiya84 at gmail.com>:
> > On Thu, Jul 22, 2010 at 11:39 AM, Wan ZongShun <mcuos.com at gmail.com>
> wrote:
> >>
> >> 2010/7/21 Kukjin Kim <kgene.kim at samsung.com>:
> >> > From: Atul Dahiya <atul.dahiya at samsung.com>
> >> >
> >> > This Patch updates existing Samsung RTC driver for clock enabling support.
> >> >
> >> > Signed-off-by: Atul Dahiya <atul.dahiya at samsung.com>
> >> > Signed-off-by: Kukjin Kim <kgene.kim at samsung.com>
> >> > ---
> >> >  drivers/rtc/rtc-s3c.c |   22 ++++++++++++++++++++++
> >> >  1 files changed, 22 insertions(+), 0 deletions(-)
> >> >
> >> > diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c
> >> > index 70b68d3..c032a15 100644
> >> > --- a/drivers/rtc/rtc-s3c.c
> >> > +++ b/drivers/rtc/rtc-s3c.c
> >> > @@ -1,5 +1,8 @@
> >> >  /* drivers/rtc/rtc-s3c.c
> >> >  *
> >> > + * Copyright (c) 2010 Samsung Electronics Co., Ltd.
> >> > + *             http://www.samsung.com/
> >> > + *
> >> >  * Copyright (c) 2004,2006 Simtec Electronics
> >> >  *     Ben Dooks, <ben at simtec.co.uk>
> >> >  *     http://armlinux.simtec.co.uk/
> >> > @@ -39,6 +42,7 @@ enum s3c_cpu_type {
> >> >
> >> >  static struct resource *s3c_rtc_mem;
> >> >
> >> > +static struct clk *rtc_clk;
> >> >  static void __iomem *s3c_rtc_base;
> >> >  static int s3c_rtc_alarmno = NO_IRQ;
> >> >  static int s3c_rtc_tickno  = NO_IRQ;
> >> > @@ -431,6 +435,10 @@ static int __devexit s3c_rtc_remove(struct
> platform_device *dev)
> >> >        s3c_rtc_setpie(&dev->dev, 0);
> >> >        s3c_rtc_setaie(0);
> >> >
> >> > +       clk_disable(rtc_clk);
> >> > +       clk_put(rtc_clk);
> >> > +       rtc_clk = NULL;
> >> > +
> >> >        iounmap(s3c_rtc_base);
> >> >        release_resource(s3c_rtc_mem);
> >> >        kfree(s3c_rtc_mem);
> >> > @@ -488,6 +496,16 @@ static int __devinit s3c_rtc_probe(struct
> platform_device *pdev)
> >> >                goto err_nomap;
> >> >        }
> >> >
> >> > +       rtc_clk = clk_get(&pdev->dev, "rtc");
> >>
> >> Do you really need the second argument? I think the bus clock for
> >> a device should be findable with NULL for s3c platform..
> >
> > No, actually  clk_get() function for s3c platform searches on the
> > basis of second parameter passed
> > so need to pass the second argument here.
> 
> Okay, good patch!
> 
> Acked-by: Wan ZongShun <mcuos.com at gmail.com>
> 
Thanks for your review and ack.

As I asked to Alessandro, does this goes through what subsystem go to upstream?

(snip)

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim at samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.