Pull request mxc

Russell King - ARM Linux linux at arm.linux.org.uk
Mon Jul 26 06:32:19 EDT 2010


On Mon, Jul 26, 2010 at 10:28:55AM +0100, Russell King - ARM Linux wrote:
> On Mon, Jul 26, 2010 at 11:00:14AM +0200, Sascha Hauer wrote:
> >  160 files changed, 6547 insertions(+), 3276 deletions(-)
> 
> I get:
> 
> 160 files changed, 6530 insertions(+), 3265 deletions
> 
> which seems to be down to this difference between your diffstat and mine:
> 
> > arch/arm/mach-mx3/mach-mx31lilly.c                 |   48 +-
> 
>  arch/arm/mach-mx3/mach-mx31lilly.c                 |   20 +-
> 
> This seems to be down to 4d5d859 (ARM: mx3: mx31lilly: fix build error for
> !CONFIG_USB_ULPI).

Err...

commit 10ee61384e444133e4d2cf2a1f21fdd50c2be297
Author: Baruch Siach <baruch at tkos.co.il>
Date:   Sun Jul 4 07:55:10 2010 +0300

    mx2_camera: Add soc_camera support for i.MX25/i.MX27

    This is the soc_camera support developed by Sascha Hauer for the i.MX27.  Alan
    Carvalho de Assis modified the original driver to get it working on more recent
    kernels. I modified it further to add support for i.MX25. This driver has been
    tested on i.MX25 and i.MX27 based platforms.

    Signed-off-by: Baruch Siach <baruch at tkos.co.il>
    Acked-by: Guennadi Liakhovetski <g.liakhovetski at gmx.de>
    Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>

Why has no one from the V4L community reviewed this patch?

Why are you using void __iomem * with the virtual address returned from
dma_alloc_coherent()?  It doesn't return IOMEM addresses!

Dropped this pull.




More information about the linux-arm-kernel mailing list