[spi-devel-general] [PATCH 2/2] SPI: make the moved loopback test work
linus.ml.walleij at gmail.com
Sun Jul 25 04:14:19 EDT 2010
2010/7/25 Grant Likely <grant.likely at secretlab.ca>:
> What's disagreed with is the dummy device knowing the intimate working
> details of the SPI bus driver.
OK I'll send the other patch I've been holding back, it merges that part into
the driver itself so it sits in the apropriate containment, and solves
that specific issue.
But I understood Davids criticism like this: "you shouldn't make tests
using loopback for a specific driver, it should be generic, i.e. being
able to perform a loopback test on any driver supporting SPI_LOOP".
A generic loopback test is a lot harder for me to produce, that's
why I was troubled...
More information about the linux-arm-kernel