[PATCH v2 7/8] ARM: S5PV310: Add Board support file

[Kukjin Kim]

Kyungmin Park wrote:
> 
> On Fri, Jul 16, 2010 at 5:58 PM, Kukjin Kim <kgene.kim at samsung.com> wrote:
> > From: Changhwan Youn <chaos.youn at samsung.com>
> >
> > This patch adds Samsung SMDKV310 board support file.
> >
> > Signed-off-by: Changhwan Youn <chaos.youn at samsung.com>
> > Signed-off-by: Kukjin Kim <kgene.kim at samsung.com>
> > ---
> >  arch/arm/mach-s5pv310/Makefile        |    4 ++
> >  arch/arm/mach-s5pv310/mach-smdkv310.c |   92
> +++++++++++++++++++++++++++++++++
> >  2 files changed, 96 insertions(+), 0 deletions(-)
> >  create mode 100644 arch/arm/mach-s5pv310/mach-smdkv310.c
> >
> > diff --git a/arch/arm/mach-s5pv310/Makefile
b/arch/arm/mach-s5pv310/Makefile
> > index 1b263a5..56e7693 100644
> > --- a/arch/arm/mach-s5pv310/Makefile
> > +++ b/arch/arm/mach-s5pv310/Makefile
> > @@ -18,3 +18,7 @@ obj-$(CONFIG_CPU_S5PV310)     += setup-i2c0.o time.o
> >  obj-$(CONFIG_SMP)              += platsmp.o headsmp.o
> >  obj-$(CONFIG_LOCAL_TIMERS)     += localtimer.o
> >  obj-$(CONFIG_HOTPLUG_CPU)      += hotplug.o
> > +
> > +# machine support
> > +
> > +obj-$(CONFIG_MACH_SMDKV310)    += mach-smdkv310.o
> > diff --git a/arch/arm/mach-s5pv310/mach-smdkv310.c b/arch/arm/mach-
> s5pv310/mach-smdkv310.c
> > new file mode 100644
> > index 0000000..0d6ab77
> > --- /dev/null
> > +++ b/arch/arm/mach-s5pv310/mach-smdkv310.c
> > @@ -0,0 +1,92 @@
> > +/* linux/arch/arm/mach-s5pv310/mach-smdkv310.c
> > + *
> > + * Copyright (c) 2010 Samsung Electronics Co., Ltd.
> > + *             http://www.samsung.com/
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License version 2 as
> > + * published by the Free Software Foundation.
> > +*/
> > +
> > +#include <linux/serial_core.h>
> > +
> > +#include <asm/mach/arch.h>
> > +#include <asm/mach-types.h>
> > +#include <asm/hardware/cache-l2x0.h>
> > +
> > +#include <plat/regs-serial.h>
> > +#include <plat/s5pv310.h>
> > +#include <plat/cpu.h>
> > +
> > +#include <mach/map.h>
> > +
> > +/* Following are default values for UCON, ULCON and UFCON UART
registers
> */
> > +#define SMDKV310_UCON_DEFAULT  (S3C2410_UCON_TXILEVEL |        \
> > +                                S3C2410_UCON_RXILEVEL |        \
> > +                                S3C2410_UCON_TXIRQMODE |       \
> > +                                S3C2410_UCON_RXIRQMODE |       \
> > +                                S3C2410_UCON_RXFIFO_TOI |      \
> > +                                S3C2443_UCON_RXERR_IRQEN)
> > +
> > +#define SMDKV310_ULCON_DEFAULT S3C2410_LCON_CS8
> > +
> > +#define SMDKV310_UFCON_DEFAULT (S3C2410_UFCON_FIFOMODE |       \
> > +                                S5PV210_UFCON_TXTRIG4 |        \
> > +                                S5PV210_UFCON_RXTRIG4)
> 
> UART supports the 16 triggers at 2/3. No need to setup the lower value.
> 
UFCON_DEFAULT is board specific UART configuration. Usually, we set the Tx
and Rx FIFO trigger level at 4. It does not matter. It mainly depends on the
final use of UART. If required, it can be changed later.

> > +
> > +static struct s3c2410_uartcfg smdkv310_uartcfgs[] __initdata = {
> > +       [0] = {
> > +               .hwport         = 0,
> > +               .flags          = 0,
> 
> Please remove unused flags filed.
> Previous time Mr. Shim sent the related patch.
> 
As far as I know, not applied yet.

> > +               .ucon           = SMDKV310_UCON_DEFAULT,
> > +               .ulcon          = SMDKV310_ULCON_DEFAULT,
> > +               .ufcon          = SMDKV310_UFCON_DEFAULT,
> > +       },
> > +       [1] = {
> > +               .hwport         = 1,
> > +               .flags          = 0,
> > +               .ucon           = SMDKV310_UCON_DEFAULT,
> > +               .ulcon          = SMDKV310_ULCON_DEFAULT,
> > +               .ufcon          = SMDKV310_UFCON_DEFAULT,
> > +       },
> > +       [2] = {
> > +               .hwport         = 2,
> > +               .flags          = 0,
> > +               .ucon           = SMDKV310_UCON_DEFAULT,
> > +               .ulcon          = SMDKV310_ULCON_DEFAULT,
> > +               .ufcon          = SMDKV310_UFCON_DEFAULT,
> > +       },
> > +       [3] = {
> > +               .hwport         = 3,
> > +               .flags          = 0,
> > +               .ucon           = SMDKV310_UCON_DEFAULT,
> > +               .ulcon          = SMDKV310_ULCON_DEFAULT,
> > +               .ufcon          = SMDKV310_UFCON_DEFAULT,
> > +       },
> > +};
> > +
> > +static void __init smdkv310_map_io(void)
> > +{
> > +       s5p_init_io(NULL, 0, S5P_VA_CHIPID);
> > +       s3c24xx_init_clocks(24000000);
> > +       s3c24xx_init_uarts(smdkv310_uartcfgs,
> ARRAY_SIZE(smdkv310_uartcfgs));
> > +}
> > +
> > +static void __init smdkv310_machine_init(void)
> > +{
> > +#ifdef CONFIG_CACHE_L2X0
> > +       l2x0_init(S5P_VA_L2CC, 1 << 28, 0xffffffff);
> > +#endif
> > +}
> > +
> > +MACHINE_START(SMDKV310, "SMDKV310")
> > +       /* Maintainer: Kukjin Kim <kgene.kim at samsung.com> */
> > +       /* Maintainer: Changhwan Youn <chaos.youn at samsung.com> */
> > +       .phys_io        = S3C_PA_UART & 0xfff00000,
> > +       .io_pg_offst    = (((u32)S3C_VA_UART) >> 18) & 0xfffc,
> > +       .boot_params    = S5P_PA_SDRAM + 0x100,
> > +       .init_irq       = s5pv310_init_irq,
> > +       .map_io         = smdkv310_map_io,
> > +       .init_machine   = smdkv310_machine_init,
> > +       .timer          = &s5pv310_timer,
> > +MACHINE_END
> > --

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim at samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.