[PATCH 4/5] ARMv6K and ARMv7 use fault statuses 3 and 6 as Access Flag fault
Sergei Shtylyov
sshtylyov at mvista.com
Mon Jul 19 06:11:32 EDT 2010
Hello.
Kirill A. Shutsemov wrote:
> Statuses 3 (0b00011) and 6 (0x00110) of DFSR are Access Flags faults on
> ARMv6K and ARMv7. Let's patch fsr_info[] at runtime if we are on ARMv7
> or later.
> Unfortunately, we don't have runtime check for 'K' extension, so we
> can't check for it.
> Signed-off-by: Kirill A. Shutemov <kirill at shutemov.name>
[...]
> diff --git a/arch/arm/mm/alignment.c b/arch/arm/mm/alignment.c
> index 77cfdbe..d073b64 100644
> --- a/arch/arm/mm/alignment.c
> +++ b/arch/arm/mm/alignment.c
> @@ -926,8 +926,18 @@ static int __init alignment_init(void)
>
> hook_fault_code(1, do_alignment, SIGBUS, BUS_ADRALN,
> "alignment exception");
> - hook_fault_code(3, do_alignment, SIGBUS, BUS_ADRALN,
> - "alignment exception");
> +
> + /*
> + * ARMv6K and ARMv7 use fault status 3 (0b00011) as Access Flag section
> + * fault, not as alignment error.
> + *
> + * TODO: handle ARMv6K properly. Runtime check for 'K' extension is
> + * needed.
> + */
> + if (cpu_architecture() <= CPU_ARCH_ARMv6) {
> + hook_fault_code(3, do_alignment, SIGBUS, BUS_ADRALN,
> + "alignment exception");
> + }
Curly braces not neeed here. I assume you haven't run your patch thru
scripts/checkpatch.pl?
WBR, Sergei
More information about the linux-arm-kernel
mailing list