[PATCH v2 1/2] regulator: add support for regulators on the ab8500 MFD
Mark Brown
broonie at opensource.wolfsonmicro.com
Tue Jul 13 10:17:10 EDT 2010
On Tue, Jul 13, 2010 at 07:39:32PM +0530, Sundar Iyer wrote:
> + * @mask: mask to enable/disable regulator
> + * @enable: bits to enable the regulator in normal(high power) mode
Have you addressed my comments here?
> + ret = ab8500_get_best_voltage_index(rdev, min_uV, max_uV);
> + if (ret < 0) {
> + dev_dbg(rdev_get_dev(rdev),
> + "coudlnt get best voltage for regulator\n");
Typo here. Also, shouldn't your error messages be errors rather than
debug output?
More information about the linux-arm-kernel
mailing list