[RFC, PATCH 1/2] arm: don't check MMU status in every addruart macro

Jeremy Kerr jeremy.kerr at canonical.com
Mon Jul 12 21:39:31 EDT 2010


Hi Nicolas,

> - __addruart vs addruart is rather confusing.  Normally the __xyz form 
>   is used by the higher level xyz which is opposite to what is done 
>   here.

Yes, but since __addruart is private to the one file, I decided that
this was better than renaming all of the platform addruart macros.
Either way is fine with me.

However, we may not need this with the suggested return-both-addresses
approach.

> - While at it, this should be replaced altogether by a macro that simply 
>   returns both the physical address and the virtual address for the 
>   debugging IO peripheral to use.  This would make your patch #2 much 
>   straight forward too.

OK, I'll try this out.

Cheers,


Jeremy




More information about the linux-arm-kernel mailing list