[PATCH v2 3/3] ARM: Add barriers to the I/OaccessorsifARM_DMA_MEM_BUFFERABLE

Catalin Marinas catalin.marinas at arm.com
Fri Jul 9 11:02:26 EDT 2010


On Fri, 2010-07-09 at 15:34 +0100, Russell King - ARM Linux wrote:
> On Fri, Jul 09, 2010 at 03:21:23PM +0100, Catalin Marinas wrote:
> > The patch below changes the __raw_* accessors to inline functions. Do
> > you see any problem with this? This would be needed even without the I/O
> > ordering patches.
> 
> I'd suggest you try building a kernel before and after this patch and
> compare the sizes - and then look at the disassembly associated with
> these accessors.

I tried and the difference is quite big - nearly 78KB for a Thumb-2
kernel (with relatively new compiler). So I'll keep the original do
{...} while (0) implementation and propose a patch for the e1000.

-- 
Catalin




More information about the linux-arm-kernel mailing list