[PATCH] ARM: S5PV210: add clocks (struct clk).

[Kukjin Kim]

MyungJoo Ham wrote:
> 
Hi,

Please include Ben Dooks in the Cc..
And...excuse me..who is benh at kernel.crashing.org?

> Many clocks were not listed in the previous
> arch/arm/mach-s5pv210/clock.c
> 
> We have added clocks defined as CLK_GATE_IPx[] in the user manual of
> S5PV210. However, the clocks that were not turned on at the boot time
> when tested with the previous kernel versions (2.6.32, 2.6.29) are
> defined in "init_clocks_disabled" so that they are turned off at the
> boot time.

I think, no need to register all of clocks which are in the CLK_GATE_IPx
into 'init_clocks_disabled'..because it depends on each platform or project.

> 
> The clocks added from CLK_GATE_IPx are:
> 	CSIS, JPEG, FIMC0 - 2, NFCON, SROMC, TVENC, HDMI, MIXER, VP,
> 	DSIM, TSI, HOSTIF, MODEM, PCM0 - 2, I2C-HDMI-PHY, I2C-HDMI-DDC,
> 	AC97, SPDIF, SECKEY, IEM-APC, IEM-IEC, CHIP-ID, PDMA0 - 1,
> 	MDMA, DMC0 - 1, NANDXL, TZIC0 - 3, VIC0 - 3, SECJTAG, CORESIGHT,
> 	SDM, SECSS, SYSCON, GPIO, TZPC0 - 3
> 

For example...in the case of JPEG, FIMC, disabling is better at the booting
time..because can be enabled dynamically in the device driver when it is
used.
But if CORESIGHT which does not having own driver is disabled at that time,
basically can't use JTAG debugger.

So need to sort out clocks to register into 'init_clocks_disabled'

> Signed-off-by: MyungJoo Ham <myungjoo.ham at samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park at samsung.com>
> ---
>  arch/arm/mach-s5pv210/clock.c |  298
> ++++++++++++++++++++++++++++++++++++++++-
>  1 files changed, 297 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-s5pv210/clock.c b/arch/arm/mach-s5pv210/clock.c
> index b3d156c..aa2b1c5 100644
> --- a/arch/arm/mach-s5pv210/clock.c
> +++ b/arch/arm/mach-s5pv210/clock.c

(snip)

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim at samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.