[PATCH v6 3/3] input: samsung-keypad - Add samsung keypad driver
kgene.kim at samsung.com
Tue Jul 6 19:52:59 EDT 2010
Joonyoung Shim wrote:
> Hi, Naveen.
> On 6/28/2010 8:33 PM, Joonyoung Shim wrote:
> > This patch adds support for keypad driver running on Samsung cpus. This
> > driver is tested on GONI and Aquila board using S5PC110 cpu.
> > Signed-off-by: Joonyoung Shim <jy0922.shim at samsung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park at samsung.com>
> > ---
> > drivers/input/keyboard/Kconfig | 9 +
> > drivers/input/keyboard/Makefile | 1 +
> > drivers/input/keyboard/samsung-keypad.c | 491
> > 3 files changed, 501 insertions(+), 0 deletions(-)
> > create mode 100644 drivers/input/keyboard/samsung-keypad.c
> Could you please test this v6 keypad driver on your various targets?
I received the test result from Naveen.
And now he is debugging about that.
..his e-mail client has some problem..so I replied...
From: Naveen Ch
I've tested with v6 patches and they are working fine on SMDK6410, SMDKC100 and SMDKV210, except for some header inclusion (linux/sched.h) in samsung-keypad.c.
The build breaking error is like following:
(make s5pc100_defconfig and select input->keypad->samsung keypad)
drivers/input/keyboard/samsung-keypad.c: In function 'samsung_keypad_irq':
drivers/input/keyboard/samsung-keypad.c:170: error: 'TASK_UNINTERRUPTIBLE' undeclared (first use in this function)
drivers/input/keyboard/samsung-keypad.c:170: error: (Each undeclared identifier is reported only once
drivers/input/keyboard/samsung-keypad.c:170: error: for each function it appears in.)
drivers/input/keyboard/samsung-keypad.c:170: error: implicit declaration of function 'schedule_timeout'
drivers/input/keyboard/samsung-keypad.c: In function 'samsung_keypad_stop':
drivers/input/keyboard/samsung-keypad.c:202: error: 'TASK_NORMAL' undeclared (first use in this function)
make: *** [drivers/input/keyboard/samsung-keypad.o] Error 1
Kukjin Kim <kgene.kim at samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
More information about the linux-arm-kernel