[PATCH] ARM: S5PV210: Fix on SECTION_SIZE_BITS on S5PV210/S5PC110.

Kukjin Kim kgene.kim at samsung.com
Tue Jul 6 19:29:38 EDT 2010


Sergei Shtylyov wrote:

> 
> Hello.

Hi :-)
> 
> Kukjin Kim wrote:
> 
> > This patch fixes on SECTION_SIZE_BITS for Sparsemem on S5PV210/S5PC110.
> > Because smallest size of a bank on S5PV210/S5PC110 is aligned by 16MB.
> > So each section's maximum size should be 16MB.
> 
> > Reported-by: Kyongho Cho <pullip.cho at samsung.com>
> > Signed-off-by: Kukjin Kim <kgene.kim at samsung.com>
> > ---
> >  arch/arm/mach-s5pv210/include/mach/memory.h |    8 ++++++--
> >  1 files changed, 6 insertions(+), 2 deletions(-)
> 
> > diff --git a/arch/arm/mach-s5pv210/include/mach/memory.h
b/arch/arm/mach-
> s5pv210/include/mach/memory.h
> > index 379117e..4a372d8 100644
> > --- a/arch/arm/mach-s5pv210/include/mach/memory.h
> > +++ b/arch/arm/mach-s5pv210/include/mach/memory.h
> > @@ -16,8 +16,12 @@
> >  #define PHYS_OFFSET		UL(0x20000000)
> >  #define CONSISTENT_DMA_SIZE	(SZ_8M + SZ_4M + SZ_2M)
> >
> > -/* Maximum of 256MiB in one bank */
> > +/* Sparsemem support. Each section is a maximum of 16MB.
> > + * Because there are many different memory type on S5PC110(MCP),
> > + * and there is a case that having 80MB, 128MB or 256MB in one
> > + * bank.
> > +*/
> 
>     According to CodingStyle, the prefrerrable format for multi-line
comments
> is this:
> 
> /*
>   * bla
>   * bla
>   */
> 
Oh, ok..will modify.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim at samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.




More information about the linux-arm-kernel mailing list