[PATCH 2/3] leds: add LED driver for Network Space v2 LEDs

[Simon Guinot]

Hi Nicolas,

On Mon, Jul 05, 2010 at 03:01:04PM -0400, Nicolas Pitre wrote:
> On Mon, 5 Jul 2010, Simon Guinot wrote:
> 
> > From: Simon Guinot <sguinot at lacie.com>
> > 
> > This patch add a LED class driver for the dual-GPIO LEDs found on the
> > Network Space v2 board (and parents). This include Internet Space v2,
> > Network Space (Max) v2 and d2 Network v2 boards.
> > 
> > This dual-GPIO LED is wired to a CPLD and can blink in relation with the
> > SATA activity. The driver expose this capability through a "sata" sysfs
> > attribute.
> > 
> > Signed-off-by: Simon Guinot <sguinot at lacie.com>
> [...]
> 
> > +config LEDS_NS2
> > +	tristate "LED support for Network Space v2 GPIO LEDs"
> > +	depends on MACH_NETSPACE_V2 || MACH_INETSPACE_V2 || MACH_NETSPACE_MAX_V2
> 
> You could add a "default y" here.

OK

> 
> > +enum ns2_led_modes {
> > +	NS_V2_LED_OFF,
> > +	NS_V2_LED_ON,
> > +	NS_V2_LED_SATA,
> > +};
> > +
> > +struct ns2_led_mode_value {
> > +	enum ns2_led_modes	mode;
> > +	int			cmd_level;
> > +	int			slow_level;
> > +};
> > +
> > +struct ns2_led_mode_value ns2_led_modval[] = {
> > +	{ NS_V2_LED_OFF	, 1, 0 },
> > +	{ NS_V2_LED_ON	, 0, 1 },
> > +	{ NS_V2_LED_ON	, 1, 1 },
> > +	{ NS_V2_LED_SATA, 0, 0 },
> > +};
> 
> You probably want to make this static.

Yes, I want.

> 
> > diff --git a/include/linux/leds-ns2.h b/include/linux/leds-ns2.h
> > new file mode 100644
> > index 0000000..c76ebbb
> > --- /dev/null
> > +++ b/include/linux/leds-ns2.h
> 
> This is probably not the best location for this file as it is really 
> specific to a particular device and not generic for the kernel.  You 
> could create it in arch/arm/mach-kirkwood/include/mach/leds-ns2.h 
> instead, and include it with #include <mach/leds-ns2.h>.

OK

Thanks for your review.

Simon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100706/1907afce/attachment.sig>