[PATCH] ARM: Stop secondary cpus in machine_halt()
Olof Johansson
olof at lixom.net
Thu Jul 1 18:47:06 EDT 2010
ARM doesn't spin down secondary cpus on halt, which results in interrupts
being delivered even after the "System halted" message, etc.
Change that to use smp_send_stop() to halt them. Also, change the
smp_send_stop() on ARM to not do a stack dump when stopping.
Signed-off-by: Olof Johansson <olof at lixom.net>
---
arch/arm/kernel/process.c | 6 ++++++
arch/arm/kernel/smp.c | 10 ++++++----
2 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
index acf5e6f..203fc1b 100644
--- a/arch/arm/kernel/process.c
+++ b/arch/arm/kernel/process.c
@@ -191,6 +191,12 @@ __setup("reboot=", reboot_setup);
void machine_halt(void)
{
+#ifdef CONFIG_SMP
+ smp_send_stop();
+#endif
+ printk(KERN_EMERG "System halted, OK to turn off power\n");
+ local_irq_disable();
+ while (1) ;
}
diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c
index b8c3d0f..5496dea 100644
--- a/arch/arm/kernel/smp.c
+++ b/arch/arm/kernel/smp.c
@@ -467,10 +467,12 @@ static DEFINE_SPINLOCK(stop_lock);
*/
static void ipi_cpu_stop(unsigned int cpu)
{
- spin_lock(&stop_lock);
- printk(KERN_CRIT "CPU%u: stopping\n", cpu);
- dump_stack();
- spin_unlock(&stop_lock);
+ if (system_state != SYSTEM_HALT) {
+ spin_lock(&stop_lock);
+ printk(KERN_CRIT "CPU%u: stopping\n", cpu);
+ dump_stack();
+ spin_unlock(&stop_lock);
+ }
set_cpu_online(cpu, false);
--
1.5.6.5
More information about the linux-arm-kernel
mailing list