[PATCH 03/24] arm: mm: add proc info for ScorpionMP
Catalin Marinas
catalin.marinas at arm.com
Tue Aug 31 08:18:36 EDT 2010
On Fri, 2010-08-27 at 20:53 +0100, Daniel Walker wrote:
> On Fri, 2010-08-27 at 17:49 +0100, Catalin Marinas wrote:
>
> > > So your saying it makes more sense to change the msm entry into the
> > > default entry, and make the current default into the
> > > ARM11MPCore/Cortex-A9 entry?
> >
> > So my opinion is to not add any specific msm code but make the
> > __v7_setup skip the ACTLR bit setting. Then add an entry for Cortex-A9
> > to set those bits.
> >
>
> how about this? Naming is of course flexible ..
I cc'ed Santosh as well. I'm not sure whether TI are using a Cortex-A9
but with different manufacturer field (I suspect it's still 0x41).
> ScorpionMP does not have the SMP/nAMP and TLB ops broadcasting bits in
> ACTLR. These bits are only used on ARM11MPCore and Cortex-A9 from arm.
> This patch just makes it so no other arm core ends up getting these
> bits set.
>
> Signed-off-by: Daniel Walker <dwalker at codeaurora.org>
>
> ---
> arch/arm/mm/proc-v7.S | 26 +++++++++++++++++++++++++-
> 1 files changed, 25 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mm/proc-v7.S b/arch/arm/mm/proc-v7.S
> index 7aaf88a..e1b5492 100644
> --- a/arch/arm/mm/proc-v7.S
> +++ b/arch/arm/mm/proc-v7.S
> @@ -189,13 +189,14 @@ cpu_v7_name:
> * It is assumed that:
> * - cache type register is implemented
> */
> -__v7_setup:
> +__v7_armmp_setup:
Maybe __v7_ca9mp_setup. Future MP processors from ARM may not need this
bit set.
> +__v7_armmp_proc_info:
> + .long 0x410f0000 @ Required ID value
> + .long 0xff0f0000 @ Mask for ID
We could restrict it to:
.long 0x410fc090
.long 0xff0ffff0
Otherwise the patch looks fine. Thanks.
--
Catalin
More information about the linux-arm-kernel
mailing list