[PATCH] MAX8952 PMIC Driver Initial Release

[MyungJoo Ham]

Thank you for the comments. They will be applied to the next patch
revision releasing soon.

On Thu, Aug 19, 2010 at 7:46 PM, Mark Brown
<broonie at opensource.wolfsonmicro.com> wrote:
> On Thu, Aug 19, 2010 at 04:05:15PM +0900, MyungJoo Ham wrote:
>
(snip)
>
>> +     max8952_write_reg(max8952, MAX8952_REG_SYNC,
>> +                     (max8952_read_reg(max8952, MAX8952_REG_SYNC) & 0x3F) |
>> +                     ((pdata->sync_freq & 0x3) << 6));
>> +     max8952_write_reg(max8952, MAX8952_REG_RAMP,
>> +                     (max8952_read_reg(max8952, MAX8952_REG_RAMP) & 0x1F) |
>> +                     ((pdata->ramp_speed & 0x7) << 5));
>
> This looks like it should be platform data.

However, could you please clarify more about this? They are already
from platform data (pdata->ramp_speed and pdata->sync_freq).

-- 
MyungJoo Ham (함명주), Ph.D.
Mobile Software Platform Lab,
Digital Media and Communications (DMC) Business
Samsung Electronics
cell: 82-10-6714-2858