[PATCH v2] ether1: Use net_device_stats from struct net_device
Tobias Klauser
tklauser at distanz.ch
Thu Aug 19 02:14:31 EDT 2010
On 2010-08-18 at 22:10:43 +0200, David Miller <davem at davemloft.net> wrote:
> From: Stephen Hemminger <shemminger at vyatta.com>
> Date: Wed, 18 Aug 2010 08:33:04 -0700
>
> > On Wed, 18 Aug 2010 09:04:24 +0200
> > Tobias Klauser <tklauser at distanz.ch> wrote:
> >
> >>
> >> - memset (&priv(dev)->stats, 0, sizeof (struct net_device_stats));
> >> + memset(&dev->stats, 0, sizeof(struct net_device_stats));
> >
> > This is incorrect, just remove the memset. The stats are initialized
> > when device is created. The Linux device driver convention is to
> > keep stats when device is set down and brought back up; that is what
> > the majority of other drivers do.
>
> Yep, both the ether1 and ether3 patch have this problem. Looks
> like we'll see v4 coming some :-)
Thanks a lot. I'll send another updated patch. Hope I get it right this
time :-)
AFAICS there are a few other network drivers having the same problem,
I'll send patches for those too.
More information about the linux-arm-kernel
mailing list