[PATCH] input/touch: Introduce the LPC32xx touchscreen controller driver (v2)

Kevin Wells wellsk40 at gmail.com
Tue Aug 17 20:34:44 EDT 2010


Hi Ryan,

Thanks for taking the time to review this.

>> +
>> +     /*
>> +      * Set sample rate to about 240Hz per X/Y pair. A single measurement
>> +      * consists of 4 pairs which gives about a 60Hz sample rate based on
>> +      * a stable 32768Hz clock source. Values are in clocks.
>> +      * Rate is (32768 / (RTR + XCONV + RTR + YCONV + DXP + TTR + UTR) / 4
>> +      */
>
> Is the clock source internal, or at least always 32.768kHz? If not,
> should the timing be controlled via some platform data so that this
> driver is compatible with other board setups?
>

The clock source for this is internal and locked in the driver and clock control
handler at 32768Hz.

As much as I want to argue not using platform data :), I can't think of one good
reason not to use it for this (the keyscanner driver has it). I
probably should of
used it from the start.



More information about the linux-arm-kernel mailing list