[PATCH 1/2] video: amba_clcd: Fix driver clock enable/disable balance issues

Kevin Wells kevin.wells at nxp.com
Tue Aug 17 19:04:38 EDT 2010


> 
> On Wed, Aug 11, 2010 at 04:03:03PM -0700, wellsk40 at gmail.com wrote:
> > From: Kevin Wells <wellsk40 at gmail.com>
> >
> > The amba clcd clock enable and disable calls can become unbalanced.
> > This usually occurs on the first call to clcdfb_set_par() during
> > LCD init, but can also occur when the LCD enters and exits blank
> > state. This fix prevents clk_disable() from being called until
> > clk_enable() has been called first.
> >
> > Signed-off-by: Kevin Wells <wellsk40 at gmail.com>
> 
> Not quite the right way to do things, because this makes yourself the
> author of the patch which is obviously wrong.
> 
> I'll commit it myself now, as I'm about to send stuff to Linus.  I'm
> going to assume you've tested it, but as I don't know positively I
> can't add an attributation for it.
> 

Thanks for checking that in.
Sorry - I had sent another mail earlier a few weeks ago asking if you
wanted to check in that change (patch 1), but I think it got lost in
the shuffle.

Both patches are tested. You can add a "Tested by" from me if it's not
too late.




More information about the linux-arm-kernel mailing list