[PATCH v4] OpenRD: Enable SD/UART selection for serial port 1

[Russell King - ARM Linux]

On Wed, Aug 11, 2010 at 06:33:19PM +0530, Tanmay Upadhyay wrote:
> +static int __init uart1_mpp_config(void)
> +{
> +	/* Configure MPP for UART1 */
> +	unsigned int uart1_mpp_config[] = {

As the code currently stands, the compiler's output would be similar to
the output created by this:

	static unsigned int uart1_mpp_config_init[] = { ... };
	unsigned int uart1_mpp_config[ARRAY_SIZE(uart1_mpp_config_init)];
	memcpy(uart1_mpp_config, uart1_mpp_config_init, sizeof(uart1_mpp_config));

So instead:

	static unsigned int uart1_mpp_config[] __initdata = {

and either keep it inside or move it outside the function.

Sometimes, it's worth learning about compiler implementations so that
you can avoid these kinds of inefficiencies.